ui: Redesign Service List page #7605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kaxcode
commented
Apr 7, 2020
•
kaxcode
commented
- Upgrade @hashicorp/consul-api-double to 2.14.0
- Create and update tests for service-list page
- Add tag-svg to codebase
- Add InstanceCount to the service model
- Create service health-checks helper
- Update ConsulsServiceList component with styling
- Create CompositeRow styling component
- Update TagList styling
- Update ListCollection styling
- Create GridCollection for nodes page with styling
johncowen
reviewed
Apr 7, 2020
There was a problem hiding this comment.
I think this looks amazing 👏 , I love the new design here also, more room for content.
I left a few comments but I don't think any of it would be blocking at all, its just nips and tucks here and there and most is kind of up to you.
One thing I did notice that we should probably sort out is the responsiveness of it, we'd best sort that at least before we merge this.
kaxcode
force-pushed
the
ui/feature/redesign-service-list-page
branch
2 times, most recently
from
2d75ce8 to
467ce24
Compare
kaxcode
force-pushed
the
ui/feature/redesign-service-list-page
branch
from
467ce24 to
c94e81f
Compare
kaxcode
force-pushed
the
ui/feature/redesign-service-list-page
branch
2 times, most recently
from
57cfe55 to
9841129
Compare
johncowen
approved these changes
Apr 8, 2020
There was a problem hiding this comment.
I left one more comment that I'm not totally sure of, but I think this is good to merge.
I think there is a lot we'll need to do re-org wise here, but agree it would be best to get the service instance listing complete first to get a better idea of how to organize the styling for these lists as I don't think its completely clear yet how to best do this.
Top work! 👍
kaxcode
force-pushed
the
ui/feature/redesign-service-list-page
branch
from
9841129 to
02b12fc
Compare
kaxcode
added a commit
that referenced
this pull request
Apr 20, 2020
* Create GridCollection for nodes page with styling * Update ListCollection styling * Update TagList styling * Create CompositeRow styling component * Update ConsulServiceList component with styling * Create service health-checks helper * Add InstanceCount to the service model * Add tag-svg to codebase * Create and update tests for service-list page * Upgrade @hashicorp/consul-api-double to 2.14.0
johncowen
pushed a commit
that referenced
this pull request
Apr 30, 2020
* Create GridCollection for nodes page with styling * Update ListCollection styling * Update TagList styling * Create CompositeRow styling component * Update ConsulServiceList component with styling * Create service health-checks helper * Add InstanceCount to the service model * Add tag-svg to codebase * Create and update tests for service-list page * Upgrade @hashicorp/consul-api-double to 2.14.0
kaxcode
added a commit
that referenced
this pull request
May 11, 2020
* Create GridCollection for nodes page with styling * Update ListCollection styling * Update TagList styling * Create CompositeRow styling component * Update ConsulServiceList component with styling * Create service health-checks helper * Add InstanceCount to the service model * Add tag-svg to codebase * Create and update tests for service-list page * Upgrade @hashicorp/consul-api-double to 2.14.0
johncowen
pushed a commit
that referenced
this pull request
May 12, 2020
* Create GridCollection for nodes page with styling * Update ListCollection styling * Update TagList styling * Create CompositeRow styling component * Update ConsulServiceList component with styling * Create service health-checks helper * Add InstanceCount to the service model * Add tag-svg to codebase * Create and update tests for service-list page * Upgrade @hashicorp/consul-api-double to 2.14.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.