WIP: agent: use context for cancellation in agent.Start() #7609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Very minor change, but this check will be slightly more reliable and likely faster.
Replace a field on Agent with context.Context When the context is cancelled Start will exit. Termination signals cancel the context. The cancellation is deferred to shutdown the goroutine listen to the signal chan.
|
The important changes from this PR were made in #8157, so closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made these changes last week while digging into the agent command. They are not quite ready for review, but opening this PR in case anyone is interested.
Using
contextfor cancellation has a number of advantages. Primarily:Agent<-Doneand get their own channel, all of which will be closed by a singlecancel.