Various updates to support managed service provider token enhancements #7714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This release contains a fix to prevent duplicate keys in the Metadata after decoding where the output value contains pointer fields.
… token This is needed to allow for managed Consul instances to register themselves in the catalog with one of the managed service provider tokens.
mkeeler
force-pushed
the
oss-sync/msp-agent-token
branch
from
a2b02c1 to
5ddacad
Compare
hanshasselberg
approved these changes
May 4, 2020
mkeeler
force-pushed
the
oss-sync/msp-agent-token
branch
from
5ddacad to
e275664
Compare
This will emit warnings about the configs not doing anything but still allow them to be parsed. This also added the warnings for enterprise fields that we already had in OSS but didn’t change their enforcement behavior. For example, attempting to use a network segment will cause a hard error in OSS.
mkeeler
force-pushed
the
oss-sync/msp-agent-token
branch
from
e275664 to
cbe3a70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ACL.Bootstrap&ACL.BootstrapTokensRPC endpoint disabling when msp tokens are configured can now be disabled. Specifically it defaults to allowing those endpoints to remain active and will require tuning the config to enable the "disabling" of those endpoints.agent/config.Configstruct. Instead we now emit warnings for configurations that will not have any effect in Consul outside of the enterprise release. This necessitated the mapstructure update as I found in the lib that was preventing things from working quite right.