Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #7714 #7770

Merged
merged 4 commits into from
May 4, 2020
Merged

Backport #7714 #7770

merged 4 commits into from
May 4, 2020

Conversation

mkeeler
Copy link
Member

@mkeeler mkeeler commented May 4, 2020

This couldn't be auto cherry picked due to a couple of changes in master that were 1.8 specific.

All I did for this was to cherry-pick the 4 commits individually and at each step get rid of the master only code.

mkeeler added 4 commits May 4, 2020 11:37
This release contains a fix to prevent duplicate keys in the Metadata after decoding where the output value contains pointer fields.
… token

This is needed to allow for managed Consul instances to register themselves in the catalog with one of the managed service provider tokens.
This will emit warnings about the configs not doing anything but still allow them to be parsed.

This also added the warnings for enterprise fields that we already had in OSS but didn’t change their enforcement behavior. For example, attempting to use a network segment will cause a hard error in OSS.

# Conflicts:
#	agent/config/config.go
@mkeeler mkeeler added this to the 1.7.x milestone May 4, 2020
Copy link
Member

@hanshasselberg hanshasselberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkeeler mkeeler merged commit d8e8bb2 into release/1.7.x May 4, 2020
@mkeeler mkeeler deleted the backport/7714 branch May 4, 2020 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants