fix: revert golang.org/x/sys bump to avoid FreeBSD regression #7780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Temporarily pin to unreleased Serf version which removes unnecessary transitive dependency on newer version of golang.org/x/sys
hanshasselberg
added
backport/1.7
and removed
pr/do-not-merge
hanshasselberg
pushed a commit
that referenced
this pull request
May 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs hashicorp/serf#602, which should be merged and released, then the Serf dep updated in
go.modto a released version, before merging this.Temporarily pin to unreleased Serf version which removes unnecessary
transitive dependency on newer version of
golang.org/x/sysand resolves to a version prior to the introduction of the regression on FreeBSD platforms.The Serf bump in #7747 updated
golang.org/x/systo a more recent version than necessary due to an explicit indirect dependency.