xds: Allow LB policy to be configured #7810
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
dnephin
commented
May 7, 2020
|
I will move the test to the new case as suggested in #7713 (comment) , once that PR merges, and also add the docs |
dnephin
force-pushed
the
dnephin/connect-proxy-lb-config-part1
branch
2 times, most recently
from
188edd0 to
b6d9ccd
Compare
Allow users to configure the load balancer policy and settings.
But HashPolicy is not hooked up yet
dnephin
changed the title
dnephin
force-pushed
the
dnephin/connect-proxy-lb-config-part1
branch
from
b6d9ccd to
1990c5b
Compare
|
Rebased this PR with master and added some of the changes from #7728. I think what is missing is adding the HashPolicy to the route, and a test case for that change. When I worked on #7728 it requires some refactoring to be able to set the hash policy on route, and now that refactoring heavily conflicts, so I think that might need to be re-done. The refactor was done in 0c82a57 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6525, replaces #7728
This PR removes the LB types that use a hash, removing the need for a hash policy. It allows configuring the LB policy to
randomorleast_request.