Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: Create Linked Services Tab for Terminating Gateways #7858

Merged
merged 4 commits into from
May 12, 2020
Merged

ui: Create Linked Services Tab for Terminating Gateways #7858

merged 4 commits into from
May 12, 2020

Conversation

kaxcode
Copy link
Contributor

@kaxcode kaxcode commented May 12, 2020 •
edited
Loading

  • Fix to bottom border not applying to the correct <li>
  • Create Linked Services tab with styling and tests
  • Add internal endpoint gateway-services-nodes to the codebase with tests
  • Upgrade consul-api-double to version 2.15.0

Screen Shot 2020-05-12 at 2 29 17 PM

@kaxcode kaxcode added the theme/ui Anything related to the UI label May 12, 2020
@kaxcode kaxcode requested a review from a team May 12, 2020 18:28
johncowen
johncowen approved these changes May 12, 2020
View reviewed changes
Copy link
Contributor

@johncowen johncowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just fix up that spelling error before merging, then we can talk about whatever else later. 🚀

ui-v2/app/templates/dc/services/show/services.hbs Outdated Show resolved Hide resolved
ui-v2/app/templates/dc/services/show/services.hbs Outdated Show resolved Hide resolved
ui-v2/app/models/gateway.js Show resolved Hide resolved
ui-v2/app/styles/routes/dc/services/index.scss Show resolved Hide resolved
@kaxcode kaxcode force-pushed the ui/feature/terminating-gateways-detail-page branch 2 times, most recently from d46b3d1 to bbd9bbb Compare May 12, 2020 21:08
@preetapan preetapan added this to the 1.8.0 milestone May 12, 2020
@kaxcode kaxcode force-pushed the ui/feature/terminating-gateways-detail-page branch from bbd9bbb to 57d2909 Compare May 12, 2020 21:18
@kaxcode kaxcode merged commit a6d732f into ui-staging May 12, 2020
@kaxcode kaxcode deleted the ui/feature/terminating-gateways-detail-page branch May 12, 2020 21:34
kaxcode added a commit that referenced this pull request May 13, 2020
@kaxcode
ui: Create Linked Services Tab for Terminating Gateways (#7858)
2adfb42 
* Fix to bottom border not applying to the correct <li>

* Create Linked Services tab with styling and tests

* Add internal endpoint gateway-services-nodes to the codebase with tests

* Upgrade consul-api-double to version 2.15.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johncowen johncowen johncowen approved these changes

Assignees
No one assigned
Labels
theme/ui Anything related to the UI
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kaxcode @johncowen @preetapan