ui: Add blocking queries to gateways #7967
Conversation
There was a problem hiding this comment.
I just had a very quick look at this, I'll take a better pass in my morning.
One thing that stood out looking at it all together is maybe we should change the name of the repo method to something plural?
Maybe findGatewayServicesBySlug and then refer to the result of that with a plural variable name instead of a singular gateway (maybe gatewayServices or just services if we are already using that in this Route)?
I dunno, I took a quick scan just now and thats the thing that jumped out at me, so thought I'd mention before I finish up. I think the thing that got me was the items={{gateway}} just looked really strange, like I was setting a plural attribute to a singular thing.
As usual not that important in the scheme of things! But see what you think
There was a problem hiding this comment.
I took another look at this and it all looks super good to me!
I like this more now as we are reusing the Service ember-data models, and we are now also getting testing coverage of HTTP requests with namespaces here.
I left a couple of notes that are 'nice to haves' more than anything, the most important of those is moving the request into the same area as intentions/chain etc. But no biggie in the scheme of things.
Sorry to be quibbling over naming again! 😬
kaxcode
force-pushed
the
ui/feature/add-blocking-queries-to-gateways
branch
from
4b5d1db to
7d32e21
Compare
* Remove gateway endpoint adapter, model, and serializer and tests * Update service tests to handle gateway-services-nodes * Upgrade consul-api-double to 2.15.2 * Add a fairly temporary shouldReconcile method Co-authored-by: John Cowen <[email protected]>
gatewayadapter, serializer, initializer, and all related testsgateway-services-nodesendpoint to services adapter and modelgateway-services-nodesreconcilemethod being used on the data returned fromgateway-services-nodesco-authored: @johncowen