Make the Agent Cache more Context aware #8092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnephin
reviewed
Jun 11, 2020
mkeeler
force-pushed
the
bugfix/cache-notify-leak
branch
from
06b34f7 to
35a4d4d
Compare
mkeeler
force-pushed
the
bugfix/cache-notify-leak
branch
from
35a4d4d to
07248e6
Compare
Blocking queries issues will still be uncancellable (that cannot be helped until we get rid of net/rpc). However this makes it so that if calling getWithIndex (like during a cache Notify go routine) we can cancell the outer routine. Previously it would keep issuing more blocking queries until the result state actually changed.
mkeeler
force-pushed
the
bugfix/cache-notify-leak
branch
from
07248e6 to
35e4446
Compare
hashicorp-ci
pushed a commit
that referenced
this pull request
Jun 15, 2020
Blocking queries issues will still be uncancellable (that cannot be helped until we get rid of net/rpc). However this makes it so that if calling getWithIndex (like during a cache Notify go routine) we can cancell the outer routine. Previously it would keep issuing more blocking queries until the result state actually changed.
|
Judging by the number of mentions, this wasn't cherry-picked into every branch |
|
It wasn't cherry-pickable into release/1.6.x or release/1.7.x due to other changes to the cache. If we want it in those branches at any time we will have to backport more than just this manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocking queries issues will still be uncancellable (that cannot be helped until we get rid of net/rpc). However this makes it so that if calling getWithIndex (like during a cache Notify go routine) we can cancell the outer routine. Previously it would keep issuing more blocking queries until the result state actually changed.
This prevents leaking of go routines by the agents ServiceManager used for resolving a services full configuration with central config entries.
TODOS: