ui: HealthCheck Search/Sort/Filtering #9314
Conversation
|
I have a weird failing test here, converted to draft whilst I sort it out |
1. Makes a HealthCheck model fragment and uses it in ServiceInstances and Nodes 2. Manually adds a relationship between a ServiceInstance and its potential ServiceInstanceProxy 3. Misc changes related to the above such as an Exposed property on MeshChecks, MeshChecks itself
johncowen
force-pushed
the
ui/feature/health-check-search-sort
branch
from
b6c6dc2 to
81c722b
Compare
|
@kaxcode just a quick ping to say this is ready for review now 🙇 |
| getModelName() { | ||
| return modelName; | ||
| } | ||
|
|
||
| findByService(slug, dc, nspace, configuration = {}) { | ||
| async findByService(slug, dc, nspace, configuration = {}) { |
There was a problem hiding this comment.
are we using the async in this file?
There was a problem hiding this comment.
Yeah, we pretty much went to 'we are an ES6 project now' with that native class codemod we did, so I'm trying to add async style to things as I go. If I happen to be working on something else and need to touch a file, I'll update what is straightforwards to async, unless there's a specific reason not to.
@kaxcode did you mean to approve this? |
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/292828. |
|
🍒✅ Cherry pick of commit 2061bff onto |
* Adds model layer changes around HealthChecks 1. Makes a HealthCheck model fragment and uses it in ServiceInstances and Nodes 2. Manually adds a relationship between a ServiceInstance and its potential ServiceInstanceProxy 3. Misc changes related to the above such as an Exposed property on MeshChecks, MeshChecks itself * Add a potential temporary endpoint to distinguish ProxyServiceInstance * Fix up Node search bar class * Add search/sort/filter logic * Fixup Service default sort key * Add Healthcheck search/sort/filtering * Tweak CSS add a default Type of 'Serf' when type is blank * Fix up tests and new test support * Add ability to search on Service/Node name depending on where you are * Fixup CheckID search predicate * Use computed for DataCollection to use caching * Alpha sort the Type menu * Temporary fix for new non-changing style Ember Proxys * Only special case EventSource proxies
|
Should this have had a changelog entry? |
|
Not necessarily this PR exactly, but maybe a bunch of PRs (which are still ongoing) under 'redesigned search/sort/filtering' or similar. |
This PR adds search, sort and filtering to the healthcheck tabs in both Node and ServiceInstance views.
In doing this, we added a new HealthCheck model fragment and stitched ServiceInstances and their ProxyServiceInstances together a little more - ProxyServiceInstances are now a JS instance of our
Proxymodel (soon to be renamedProxyInstance) which inherits from a ourServiceInstancemodel, this means thatProxyServiceInstances now take on the properties of the responses of both the API endpoint we use for proxy meta endpoint and the API endpoint we use for service instance endpoint.We also added some further computed properties onto these models (
ServiceInstance.MeshChecks,.HealthCheck.Exposableand.HealthCheck.Exposed)Lastly a tiny addition here is that we noticed that a HealthCheck can have an empty Type (
""), which seems to be only for the serf related healthchecks that Consul automatically adds to services, so we filled in theTypein the template withserfwhen its blank.