introduce certopts #9606
Merged
introduce certopts #9606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
theme/certificates
hanshasselberg
force-pushed
the
cert_opts
branch
from
77db4a6 to
b2678b8
Compare
hanshasselberg
commented
Jan 21, 2021
|
|
||
| // generate leaf | ||
| serial, err := tlsutil.GenerateSerialNumber() | ||
| signer, _, err := tlsutil.GeneratePrivateKey() |
There was a problem hiding this comment.
I think I forgot to fix this one in CAOpts: the same signer needs to be used for CA and certs.
|
@i0rek is there anything else you would like to add here? |
hanshasselberg
force-pushed
the
cert_opts
branch
from
b2678b8 to
e117682
Compare
hanshasselberg
added
the
pr/no-changelog
|
@freddygv I revisited the PR and did it all over again. Should be good now. |
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/341317. |
|
🍒✅ Cherry pick of commit 53e9c13 onto |
hashicorp-ci
pushed a commit
that referenced
this pull request
Mar 22, 2021
* introduce cert opts * it should be using the same signer * lint and omit serial
|
🍒✅ Cherry pick of commit 53e9c13 onto |
hashicorp-ci
pushed a commit
that referenced
this pull request
Mar 22, 2021
* introduce cert opts * it should be using the same signer * lint and omit serial
dizzyup
pushed a commit
that referenced
this pull request
Apr 21, 2021
* introduce cert opts * it should be using the same signer * lint and omit serial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I liked
CAOptsfrom #9585 so much that I addedCertOptsas well.