streaming: fix snapshot cache bug #9772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when the cache entry is created from resuming a stream.
dnephin
added
type/bug
|
🤔 Double check that this PR does not require a changelog entry in the |
Previously a snapshot created as part of a resumse-stream request could have incorrectly cached the newSnapshotToFollow event. This would cause clients to error because they received an unexpected framing event.
dnephin
force-pushed
the
streamin-fix-bad-cached-snapshot
branch
from
be3c23f to
ba3a1b9
Compare
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/328108. |
|
🍒✅ Cherry pick of commit 363d738 onto |
hashicorp-ci
pushed a commit
that referenced
this pull request
Feb 16, 2021
streaming: fix snapshot cache bug
dizzyup
pushed a commit
that referenced
this pull request
Apr 21, 2021
streaming: fix snapshot cache bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously a snapshot created as part of a resume-stream request could have incorrectly cached the
newSnapshotToFollowevent. When the next subscribe request was received withIndex=0the returned snapshot would cause clients to error because they received an unexpected framing event.Fixed the bug by saving a snapshot without the framing event, then creating a new snapshot to prepend the framing event.