-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump components to remove client-side md processing #9773
Conversation
🤔 This PR has changes in the |
🤔 Double check that this PR does not require a changelog entry in the |
@@ -18,27 +18,27 @@ export default function CommunityPage() { | |||
{ | |||
header: 'Community Forum', | |||
body: | |||
'[Consul Community Forum](https://discuss.hashicorp.com/c/consul)', | |||
'<a href="https://discuss.hashicorp.com/c/consul">Consul Community Forum</a>', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vertical-text-block-list
no longer processes markdown internally, so we need to pass it HTML instead. This could be done automatically in getStaticProps
if we feel it'd be worth it for authoring convenience.
@@ -21,7 +21,6 @@ | |||
@import '~@hashicorp/react-product-downloader/dist/style.css'; | |||
@import '~@hashicorp/react-product-features-list/style.css'; | |||
@import '~@hashicorp/react-search/style.css'; | |||
@import '~@hashicorp/react-section-header/style.css'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
section-header
now uses CSS modules, so this CSS import is no longer needed.
@@ -1,4 +1,6 @@ | |||
#p-community { | |||
--brand: var(--consul); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This ensures links within vertical-text-block-list
are styled correctly.
Note: I need to add the |
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/328399. |
🍒✅ Cherry pick of commit 531854b onto |
🍒✅ Cherry pick of commit 531854b onto |
This PR bumps
@hashicorp/react-vertical-text-block-list
and@hashicorp/react-section-header
to recently published versions which do not process markdown within the component.Affected pages
/community
, should be identical to live site, except the link color should now be "Consul pink", as the current blue link colour is a minor visual bug