Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update helm docs for consul-helm v0.30.0 #9779

Merged
merged 1 commit into from
Feb 17, 2021
Merged

Update helm docs for consul-helm v0.30.0 #9779

merged 1 commit into from
Feb 17, 2021

Conversation

thisisnotashwin
Copy link
Contributor

No description provided.

@thisisnotashwin thisisnotashwin added type/docs Documentation needs to be created/updated/clarified type/docs-cherrypick labels Feb 17, 2021
kschoche
kschoche reviewed Feb 17, 2021
View reviewed changes
website/content/docs/k8s/helm.mdx
@@ -278,7 +278,7 @@ and consider if they're appropriate for your deployment.
enable `server.exposeGossipAndRPCPorts` and `client.exposeGossipPorts`,
that will configure the LAN gossip ports on the servers and clients to be
hostPorts, so if you are running clients and servers on the same node the
ports will conflict if they are both 8301. When you enable
ports will conflict if they are both 8301. When you enable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ports will conflict if they are both 8301. When you enable
ports will conflict if they are both 8301. When you enable

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed here: https://github.com/hashicorp/consul-helm/pull/832/files

@hashicorp-ci
Copy link
Contributor

🤔 This PR has changes in the website/ directory but does not have a type/docs-cherrypick label. If the changes are for the next version, this can be ignored. If they are updates to current docs, attach the label to auto cherrypick to the stable-website branch after merging.

@hashicorp-ci
Copy link
Contributor

🤔 Double check that this PR does not require a changelog entry in the .changelog directory. Reference

kschoche
kschoche approved these changes Feb 17, 2021
View reviewed changes
Copy link
Contributor

@kschoche kschoche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@thisisnotashwin thisisnotashwin merged commit cd42806 into master Feb 17, 2021
@thisisnotashwin thisisnotashwin deleted the update-helm-docs branch February 17, 2021 19:08
@hashicorp-ci
Copy link
Contributor

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/328816.

@hashicorp-ci
Copy link
Contributor

🍒✅ Cherry pick of commit cd42806 onto stable-website succeeded!

hashicorp-ci pushed a commit that referenced this pull request Feb 17, 2021
@hashicorp-ci
Update helm docs for consul-helm v0.30.0 (#9779)
28bfc8b
@hashicorp-ci
Copy link
Contributor

🍒✅ Cherry pick of commit cd42806 onto release/1.9.x succeeded!

hashicorp-ci pushed a commit that referenced this pull request Feb 17, 2021
@hashicorp-ci
Update helm docs for consul-helm v0.30.0 (#9779)
09802dd
@lkysow lkysow mentioned this pull request Feb 18, 2021
Merged
1 task
dizzyup pushed a commit that referenced this pull request Apr 21, 2021
@dizzyup
Update helm docs for consul-helm v0.30.0 (#9779)
f476f29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkysow lkysow lkysow left review comments

@ishustava ishustava ishustava approved these changes

@kschoche kschoche kschoche approved these changes

@ndhanushkodi ndhanushkodi ndhanushkodi approved these changes

Assignees
No one assigned
Labels
type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@thisisnotashwin @hashicorp-ci @lkysow @ndhanushkodi @kschoche @ishustava