-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: Side navigation tweaks #9812
Conversation
🤔 Double check that this PR does not require a changelog entry in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the color of the version needs to be changed to be the same as the section headers (ui-gray-400). Font size also should be 12px |
Hey @jnwright Oh good spot! I knocked the gray on the version down a couple of notches so its equivalent to We use relative sizes for font-sizing (not pixels), the version is Lemme know if that makes sense. |
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/332197. |
This PR adds a few little amends to the new sidebar navigation: