Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Side navigation tweaks #9812

Merged
merged 6 commits into from
Feb 25, 2021
Merged

ui: Side navigation tweaks #9812

merged 6 commits into from
Feb 25, 2021

Conversation

johncowen
Copy link
Contributor

This PR adds a few little amends to the new sidebar navigation:

  1. Larger Consul logo
  2. Use dark menus for header menus as well as side menus.
  3. Remove app footer and move Consul version output to the Help menu
  4. Revert unique ID usage so we can keep using the login modal id throughout the app to toggle it instead of having to pass around JS things.

@johncowen johncowen added the theme/ui Anything related to the UI label Feb 23, 2021
@johncowen johncowen requested a review from kaxcode February 23, 2021 12:23
@hashicorp-ci
Copy link
Contributor

🤔 Double check that this PR does not require a changelog entry in the .changelog directory. Reference

Copy link
Contributor

@kaxcode kaxcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jnwright
Copy link
Contributor

Looks like the color of the version needs to be changed to be the same as the section headers (ui-gray-400). Font size also should be 12px

@johncowen
Copy link
Contributor Author

Hey @jnwright

Oh good spot! I knocked the gray on the version down a couple of notches so its equivalent to ui-gray-400.

We use relative sizes for font-sizing (not pixels), the version is 0.75rem which, in our app, equates to 12px.

Lemme know if that makes sense.

@johncowen johncowen merged commit 779f7f7 into master Feb 25, 2021
@johncowen johncowen deleted the ui/feature/side-nav-tweaks branch February 25, 2021 09:35
@hashicorp-ci
Copy link
Contributor

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/332197.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/ui Anything related to the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants