Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update NIA Security Model for Beta #9815

Merged
merged 8 commits into from
Feb 23, 2021
Merged

Update NIA Security Model for Beta #9815

merged 8 commits into from
Feb 23, 2021

Conversation

picatz
Copy link
Contributor

@picatz picatz commented Feb 23, 2021

This PR introduces some minor updates to the NIA security model for the beta.

  • Change from Tech Preview to Beta in the sidebar
  • Update the overview section to better reflect the other NIA docs.
  • Changes to the "NIA Daemon" wording to also refer to consul-terraform-sync, using them interchangeably where I thought it made sense.

@picatz
Replace tech preview with beta in sidebar title
7f01df5
@picatz
Update overview section to reflect other NIA docs better
9e2aee6
@picatz
Simplify start of the personas sections
01b4c54
@picatz
Update the NIA daemon wording usage
5fdf053 
This document used the "NIA daemon", which essentially refers to the consul-terraform-sync binary running in daemon mode.

I think it makes sense to use "`consul-terraform-sync`", "NIA daemon", and "daemon" interchangeably, depending on context.
@picatz
Drop the arguably unnecessary product reference
43145f5 
I really love Nomad, and this might still be nice to have... but also not totally needed in this document.
@picatz
Favor full "and" instead of ampersand
8a33858
@picatz
Update usage of catalog in the overview
13c6060
@picatz picatz added type/docs Documentation needs to be created/updated/clarified type/docs-cherrypick theme/consul-terraform-sync Relating to Consul Terraform Sync and Network Infrastructure Automation labels Feb 23, 2021
@picatz picatz requested a review from a team February 23, 2021 20:48
@picatz picatz self-assigned this Feb 23, 2021
@github-actions github-actions bot removed the theme/consul-terraform-sync Relating to Consul Terraform Sync and Network Infrastructure Automation label Feb 23, 2021
@hashicorp-ci
Copy link
Contributor

🤔 This PR has changes in the website/ directory but does not have a type/docs-cherrypick label. If the changes are for the next version, this can be ignored. If they are updates to current docs, attach the label to auto cherrypick to the stable-website branch after merging.

@hashicorp-ci
Copy link
Contributor

🤔 Double check that this PR does not require a changelog entry in the .changelog directory. Reference

@vercel vercel bot temporarily deployed to Preview – consul-ui-staging February 23, 2021 20:51 Inactive
eikenb
eikenb approved these changes Feb 23, 2021
View reviewed changes
Copy link
Contributor

@eikenb eikenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read through everything once and it sounds good. Naming changes looks good.
👍

@findkim
Copy link
Contributor

findkim commented Feb 23, 2021

@picatz Do you mind changing the destination branch from master to the branch for the next release nia/docs-0.1.0-beta? Once it's merged there we can push these changes together with the other 0.1.0-beta docs.

@picatz
Copy link
Contributor Author

picatz commented Feb 23, 2021 •
edited
Loading

No problem @findkim, will update the destination branch now. 😄

@picatz picatz changed the base branch from master to nia/docs-0.1.0-beta February 23, 2021 21:34
@picatz picatz requested a review from findkim February 23, 2021 21:42
@findkim findkim force-pushed the nia/docs-0.1.0-beta branch from b56913e to 61e33b1 Compare February 23, 2021 21:47
@findkim
Copy link
Contributor

findkim commented Feb 23, 2021

Thanks! I just rebased the branch so the diffs in this PR aren't huge.

@picatz
Copy link
Contributor Author

picatz commented Feb 23, 2021

Awesome, thank you!

@picatz picatz merged commit 21def3a into nia/docs-0.1.0-beta Feb 23, 2021
@picatz picatz deleted the nia/docs-security-model-beta branch February 23, 2021 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@findkim findkim findkim approved these changes

@eikenb eikenb eikenb approved these changes

Assignees

@picatz picatz

Labels
type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@picatz @hashicorp-ci @findkim @eikenb