resolve @ember/render-modifiers to ^2.x #651
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
This change forces the monorepo to use a 2.x version of the
@ember/render-modifiers
package to work around an issue blocking the{{did-insert}}
helper from working correctly in the new website.🛠️ Detailed description
The website project relies on
field-guide
which has a dependency onember-prism
which has a dependency on an old1.x
version of@ember/render-modifiers
. That version has logic to do a "capabilities" check to see if the current version of Ember is 3.13 which breaks when used in our newer website app. This logic was removed andember-prism
has been updated to use this, however, upgrading ember-prism in field-guide has not happened yet.This PR leverages yarn's resolution feature to force the issue and only use the lastest version of
@ember/render-modifiers
within the monorepo.📸 Screenshots
Before
After
🔗 External links
👀 How to review
👉 Review commit-by-commit
👉 Review by files changed
Reviewer's checklist:
💬 Please consider using conventional comments when reviewing this PR.