Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve @ember/render-modifiers to ^2.x #651

Merged
merged 1 commit into from
Oct 24, 2022
Merged

resolve @ember/render-modifiers to ^2.x #651

merged 1 commit into from
Oct 24, 2022

Conversation

Dhaulagiri
Copy link
Collaborator

@Dhaulagiri Dhaulagiri commented Oct 24, 2022

📌 Summary

This change forces the monorepo to use a 2.x version of the @ember/render-modifiers package to work around an issue blocking the {{did-insert}} helper from working correctly in the new website.

🛠️ Detailed description

The website project relies on field-guide which has a dependency on ember-prism which has a dependency on an old 1.x version of @ember/render-modifiers. That version has logic to do a "capabilities" check to see if the current version of Ember is 3.13 which breaks when used in our newer website app. This logic was removed and ember-prism has been updated to use this, however, upgrading ember-prism in field-guide has not happened yet.

This PR leverages yarn's resolution feature to force the issue and only use the lastest version of @ember/render-modifiers within the monorepo.

📸 Screenshots

image

Before

~/c/w/design-system (new-docs-website/spike-html-to-markdown↑19↓208|●3✚1) $ yarn why @ember/render-modifiers
├─ ember-basic-dropdown@npm:6.0.1
│  └─ @ember/render-modifiers@npm:2.0.4 [411b6] (via npm:^1.0.2 || ^2.0.0 [411b6])
│
├─ ember-cli-clipboard@npm:0.16.0
│  └─ @ember/render-modifiers@npm:2.0.4 [411b6] (via npm:^1.0.2 || ^2.0.0 [411b6])
│
├─ ember-prism@npm:0.10.0
│  └─ @ember/render-modifiers@npm:1.0.2 (via npm:^1.0.2)
│
└─ ember-prism@npm:0.12.0
   └─ @ember/render-modifiers@npm:2.0.4 [411b6] (via npm:^1.0.2 || ^2.0.0 [411b6])

After

~/c/w/design-system (br-render|✔) $ yarn why @ember/render-modifiers
├─ ember-basic-dropdown@npm:6.0.1
│  └─ @ember/render-modifiers@npm:2.0.4 [411b6] (via npm:^2.0.0 [411b6])
│
├─ ember-cli-clipboard@npm:0.16.0
│  └─ @ember/render-modifiers@npm:2.0.4 [411b6] (via npm:^2.0.0 [411b6])
│
├─ ember-prism@npm:0.10.0
│  └─ @ember/render-modifiers@npm:2.0.4 [411b6] (via npm:^2.0.0 [411b6])
│
└─ ember-prism@npm:0.12.0
   └─ @ember/render-modifiers@npm:2.0.4 [411b6] (via npm:^2.0.0 [411b6])

🔗 External links


👀 How to review

👉 Review commit-by-commit
👉 Review by files changed

Reviewer's checklist:

  • +1 Percy if applicable
  • Confirm that PR has a changelog update via Changesets if needed

💬 Please consider using conventional comments when reviewing this PR.

@Dhaulagiri Dhaulagiri requested a review from didoo October 24, 2022 19:23
@vercel
Copy link

vercel bot commented Oct 24, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
hds-components ✅ Ready (Inspect) Visit Preview Oct 24, 2022 at 7:23PM (UTC)
hds-flight-website ✅ Ready (Inspect) Visit Preview Oct 24, 2022 at 7:23PM (UTC)
hds-website ✅ Ready (Inspect) Visit Preview Oct 24, 2022 at 7:23PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2022

⚠️ No Changeset found

Latest commit: f1a32f1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@didoo didoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust it works :)

@Dhaulagiri
Copy link
Collaborator Author

I trust it works :)

We can trust but verify 😄 . I think I had an accurate reproduction locally when I got this working but if we find this didn't do the trick I can revisit this.

@Dhaulagiri Dhaulagiri merged commit 793f8fe into main Oct 24, 2022
@Dhaulagiri Dhaulagiri deleted the br-render branch October 24, 2022 20:05
@alex-ju alex-ju added the docs-website Content updates to the documentation website label Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-website Content updates to the documentation website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants