-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add stable redirect for Nomad envoy troubleshooting #1585
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
Some suggested prefixes and emojis that may help to write clear, actionable code review comments:
Expand for comment prefix descriptions
|
π¦ Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action π€ This PR introduced no changes to the javascript bundle π |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the @hashicorp/dev-portal can clarify this, but I think we can still add redirects to https://github.com/hashicorp/nomad/blob/main/website/redirects.js?
I wonder if these /s
redirects should be kept there so we can find them more easily while searching the codebase.
@lgfa29 Do you want this redirect to root from developer? The redirects in this context are from the .io domain. Since all the docs paths are redirected from that domain, we should only add new redirects from the developer root. Unless this is an old unsupported .io redirected path? If you want to add a redirect for developer, you add it in the redirects.js file in the nomad repo (I saw you added some on your PR). |
Hum...not sure if I follow so let me explain our use case for these. We have some URLs that are hardcoded in our codebase to point users to more expansive documentation. For example here: https://github.com/hashicorp/nomad/blob/v1.4.3/nomad/plan_apply.go#L551 The tricky part is that the documentation we point to may change, like if we write better docs somewhere else, so these So what we need is that these redirects work, because that's what we're using in our code:
What I mentioned was that having the redirects declared in our repo would be helpful since they would be closer to the code that references them. So are there any concerns in always adding these |
π Relevant links
Nomad PR: hashicorp/nomad#15908
ποΈ What
In that ^ PR, I'm adding a link to an error message and would like to use this short and stable redirect link.