Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add stable redirect for Nomad envoy troubleshooting #1585

Merged
merged 3 commits into from
Feb 2, 2023

Conversation

gulducat
Copy link
Member

πŸ”— Relevant links

Nomad PR: hashicorp/nomad#15908

πŸ—’οΈ What

In that ^ PR, I'm adding a link to an error message and would like to use this short and stable redirect link.

@gulducat gulducat requested a review from a team as a code owner January 27, 2023 22:36
@vercel
Copy link

vercel bot commented Jan 27, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated
dev-portal βœ… Ready (Inspect) Visit Preview πŸ’¬ Add your feedback Feb 2, 2023 at 7:51PM (UTC)

@github-actions
Copy link

Some suggested prefixes and emojis that may help to write clear, actionable code review comments:

Praise πŸ™Œ Question πŸ™‹ Thought πŸ’­ Blocker 🚧 Future πŸ“Œ Optional 🎨 Nitpick ⛏️
Expand for comment prefix descriptions
Prefix+Emoji Description
Praise πŸ™Œ Use to highlight something positive. It's nice to try to leave one per review, but don't leave false praise just to leave one of these comments.
Question πŸ™‹ Use to gain clarity from the code author. The conversation could evolve into any one of these other categories. Only the reviewer should resolve these comment threads.
Thought πŸ’­ Use to share context, leave a breadcrumb, or share an idea that came up while reviewing.
Blocker 🚧 Use to request changes that block merging the current PR. Only the reviewer should resolve these comment threads.
Future πŸ“Œ Use to request changes that the code author can choose to address in the current PR or a follow-up one.
Optional 🎨 Use to suggest optional changes that you feel strongly about but ultimately defer to the code author to make a decision on. These can be comments that turn into valuable conversation starters for adopting new code styles, guidelines, or team practices.
Nitpick ⛏️ Use to suggest changes based on loose opinions or personal preferences. The difference between this and Optional 🎨  is how strong the code reviewer's opinion is.

@gulducat gulducat requested a review from lgfa29 January 27, 2023 22:36
@github-actions
Copy link

github-actions bot commented Jan 27, 2023

πŸ“¦ Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action πŸ€–

This PR introduced no changes to the javascript bundle πŸ™Œ

Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the @hashicorp/dev-portal can clarify this, but I think we can still add redirects to https://github.com/hashicorp/nomad/blob/main/website/redirects.js?

I wonder if these /s redirects should be kept there so we can find them more easily while searching the codebase.

@kendallstrautman
Copy link
Contributor

@lgfa29 Do you want this redirect to root from developer? The redirects in this context are from the .io domain. Since all the docs paths are redirected from that domain, we should only add new redirects from the developer root. Unless this is an old unsupported .io redirected path?

If you want to add a redirect for developer, you add it in the redirects.js file in the nomad repo (I saw you added some on your PR).

@lgfa29
Copy link
Contributor

lgfa29 commented Jan 31, 2023

Hum...not sure if I follow so let me explain our use case for these.

We have some URLs that are hardcoded in our codebase to point users to more expansive documentation. For example here: https://github.com/hashicorp/nomad/blob/v1.4.3/nomad/plan_apply.go#L551

The tricky part is that the documentation we point to may change, like if we write better docs somewhere else, so these /s redirects allow us to change the content users land on without having to worry about modifying code.

So what we need is that these redirects work, because that's what we're using in our code:

What I mentioned was that having the redirects declared in our repo would be helpful since they would be closer to the code that references them.

So are there any concerns in always adding these /s redirects to https://github.com/hashicorp/nomad/blob/main/website/redirects.js instead of here?

@brkalow brkalow merged commit 0c86e1b into main Feb 2, 2023
@brkalow brkalow deleted the nomad-redirect-envoy-bootstrap-error branch February 2, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants