only setpgid on child calls if subshell is used #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes it so that only commands that use 'sh -c' to wrap a shell-script like command get setpgid set to ensure signal propagation to the process being run in the subshell. Uses new consul-template/child exported features to detect and set it (thus the CT version bump). This is needed to fix issues caused by setpgid, primarily when the sub-shell isn't used it still effects things like you can't run an interactive bash setting as the command and possibly other shell scripts.
eikenb
force-pushed
the
limit-setpgid-to-subshells
branch
from
e0c1492 to
7da7b62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it so that only commands that use 'sh -c' to wrap a shell-script
like command get setpgid set to ensure signal propagation to the process
being run in the subshell. Uses new consul-template/child exported
features to detect and set it (thus the CT version bump).
Consul-template's related PR for context: hashicorp/consul-template#1600
Fixes #305