Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the code logic to generate the required provider list. #26

Merged
merged 2 commits into from
Apr 26, 2019

Conversation

metacpp
Copy link
Contributor

@metacpp metacpp commented Apr 26, 2019

This PR is created to address the regression issue after upgrading to v0.4.0 recently:
hashicorp/terraform-provider-azurerm#3312

Before making this change, if you ran any acceptance test like TestAccAzureRMResourceGroup_basic, you will see below error:

Error: Error ensuring Resource Providers are registered: Cannot register provider Microsoft.Cdn 
with Azure Resource Manager: resources.ProvidersClient#Register: Failure responding to request:
StatusCode=404 -- Original Error: autorest/azure: Service returned an error. Status=404 
Code="InvalidResourceNamespace" Message="The resource namespace 'Microsoft.Cdn' is invalid.".

With this change, the test can pass.

@hashicorp-cla
Copy link

hashicorp-cla commented Apr 26, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @metacpp! LGTM

@katbyte katbyte added the bug Something isn't working label Apr 26, 2019
@katbyte katbyte merged commit 5e51ac0 into hashicorp:master Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants