Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdk/auth: loginEndpoint in secure cloud contains unhandled trailing slash #1152

Open
1 task done
bmoylan opened this issue Jan 28, 2025 · 0 comments · May be fixed by #1148
Open
1 task done

sdk/auth: loginEndpoint in secure cloud contains unhandled trailing slash #1152

bmoylan opened this issue Jan 28, 2025 · 0 comments · May be fixed by #1148

Comments

@bmoylan
Copy link

bmoylan commented Jan 28, 2025

Is there an existing issue for this?

  • I have searched the existing issues

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Service Used

Metadata Service's loginEndpoint

API Versions Used

2022-09-01

Description

In the usssec Azure cloud, the loginEndpoint in the response from /metadata/endpoints?api-version=2022-09-01 includes a trailing slash that the SDK and tests do not expect. This causes sdk/auth's ClientSecretAuthorizer and ClientCertificateAuthorizer to use a double-slash after appending their own leading slash for the required endpoint. Thus the terraform provider can not successfully log in with OIDC.

#1148 is a potential solution: by using the standard library's url.JoinPath, the SDK will clean unexpected double slashes and use a correct URL irrespective of the structure of the loginEndpoint.

References

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant