fix: Use url.JoinPath() to more flexibly handle extraneous slashes #1148
+41
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
the
release-once-merged
1 task
|
Hi @manicminer it looks like you've worked on a lot of the surrounding code here. Would you be able to review this change? Thanks in advance! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a custom cloud environment, we configure terraform-provider-azurerm with a
metadata_hostwhose response toGET /metadata/endpoints?api-version=2022-09-01includes a trailing slash in theloginEndpointfield. The currentSprintfapproach assumes well formed (no slashes) endpoints. The provider fails to get OIDC credentials in this environment due to the double slash at the beginning of the path returned by tokenEndpoint().In order to be more robust to this subtly unepected input, the provider can use url.JoinPath to clean missing and double slashes.
Fixes #1152