Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude Resource Manager endpoints from network failure detection #1123

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

jackofallops
Copy link
Member

Users on unstable/unreliable networks can experience terraform operation disruption. Since the extendedRetryPolicy is needed only for Data Plane clients, this PR restores previous "Retry Forever" (specifically until operation context deadline expires) behaviour for Resource Manager endpoints.

  • bump go to 1.22
  • exclude azure management endpoints from network failure logic.

exclude azure management endpoints from network failure logic.
@github-actions github-actions bot added the release-once-merged The SDK should be released once this PR is merged label Nov 25, 2024
@jackofallops jackofallops marked this pull request as ready for review November 28, 2024 07:38
@jackofallops jackofallops requested a review from a team as a code owner November 28, 2024 07:38
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typo, otherwise LGTM 🦚

sdk/client/client.go Outdated Show resolved Hide resolved
sdk/client/client.go Outdated Show resolved Hide resolved
@jackofallops jackofallops merged commit 140b04f into main Nov 28, 2024
5 checks passed
@jackofallops jackofallops deleted the b/exclude-rm-from-extended-retrypolicy branch November 28, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-once-merged The SDK should be released once this PR is merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants