discover: new config parser #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch implements a different config parser for the go-discover config language. This is a breaking change from the previous implementation since the values are no longer expected to be URL encoded but are taken as literals unless they contain a space, backslash or double-quote. In that case they need to be quoted and special characters can be escaped as usual.
|
This addresses hashicorp/consul#3417 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements a different config parser for the go-discover
config language. This is a breaking change from the previous
implementation since the values are no longer expected to be URL encoded
but are taken as literals unless they contain a space, backslash or
double-quote. In that case they need to be quoted and special characters
can be escaped as usual.