Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add go.mod #25

Merged
merged 1 commit into from
Aug 28, 2018
Merged

Add go.mod #25

merged 1 commit into from
Aug 28, 2018

Conversation

mitchellh
Copy link
Contributor

This adds a go.mod file, automatically made using:

$ go mod init
$ go test

This doesn't add any versioning yet to this module, we can tag it v1 after if you're comfortable, but I want to double check deps first.

@mitchellh mitchellh requested a review from jefferai August 26, 2018 20:33
@evanphx evanphx self-requested a review August 26, 2018 22:30
Copy link
Contributor

@evanphx evanphx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100% of those dependencies are test dependencies. Unsure how go.mod handles that (or if it should), as someone using go-hclog doesn't really need those things unless they're developing it.

@evanphx
Copy link
Contributor

evanphx commented Aug 26, 2018

Answered my own question: golang/go#26913 (comment)

@mitchellh
Copy link
Contributor Author

Yeah! If we need to lower the minimum version in this go.mod for downstreams we can do that after, but given the dependencies listed I think it'll be fine.

@evanphx evanphx merged commit 75ecd6e into master Aug 28, 2018
@evanphx evanphx deleted the f-mod branch August 28, 2018 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants