Augment keys of all metric types in the same way #112
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is unexpected that the common key prefix for some metrics types is
different. This makes it unnecessary difficult to find the metrics in
the database. This commit unifies the prefix for all metrics.
The prefix of each key is now
service name, type prefix, hostname
. Allof them are optional.
service name
is added if it is available and notset as a label because the configuration flag
EnableServiceLabel
isset.
type prefix
is added if it is enabled with the configuration flagEnableTypePrefix
.hostname
is added if it is available and not setas a label because
EnableHostnameLabel
is set.The behaviour of
EmitKeys
,IncrCounter
,IncrCounterWithLabels
,AddSample
,AddSampleWithLabels
,MeasureSince
andMeasureSinceWithLabels
changes with this commit. ForEmitKey
thehostname will be added (details see above) but the service name will no
longer be added when
EnableServiceLabel
is set totrue
. For theother types the hostname will be added if it is available and
EnableHostnameLabel
is set tofalse
.