feat(parseutil): Add ParseDurationSecondWithUnits #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows ParseDurationSecond to specify custom additional units (such as days, months, and years) which must stand independently of other units (e.g., "5d6mo7y" is not allowed, but "5d", "6mo", and "7y" are), mapping them to time.Duration values. Signed-off-by: Alexander Scheel <[email protected]>
cipherboy
force-pushed
the
cipherboy-add-durations-with-units
branch
from
46324d5 to
96d5398
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows
ParseDurationSecondto specify custom additional units (such as days, months, and years) which must stand independently of other units (e.g., "5d6mo7y" is not allowed, but "5d", "6mo", and "7y" are), mapping them to time.Duration values.Signed-off-by: Alexander Scheel <[email protected]>I was going to use this when parsing configuration values for the health check, to allow durations longer than days to be parsed. For things like CA validity period and other long-lived values, this'd be generally useful I think.
Note that this isn't a full-featured reimplementation of https://cs.opensource.google/go/go/+/refs/tags/go1.19.2:src/time/format.go;l=1522 with custom units though; the existing behavior is preserved (requiring exclusivity of units).