Add Query
and Status
query param fields to OrganizationMembershipListOptions
#550
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds two missing fields supported by our List Organization Memberships API:
q
: A search query string. Organization memberships are searchable by user name and email.filter[status]
: If specified, restricts results to those with the matching status value. Valid values areinvited
andactive
One thing to note is that we skip one of the query string tests because it depends on being able to assign a username to the user of an organization membership. A test like this requires Account API support, which go-tfe currently does not support. Once supported, we can update the skipped test to be able to dynamically assign usernames and thus make them query-able.
Testing plan
go test -v ./... -run TestOrganizationMembershipsList -tags=integration
External links