-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hs26gill/TF-5101-Add-name-filter-for-listing-projects #668
Merged
hs26gill
merged 2 commits into
main
from
hs26gill/TF-5101-Add-name-filter-for-listing-projects
Mar 28, 2023
Merged
hs26gill/TF-5101-Add-name-filter-for-listing-projects #668
hs26gill
merged 2 commits into
main
from
hs26gill/TF-5101-Add-name-filter-for-listing-projects
Mar 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonc
reviewed
Mar 23, 2023
hs26gill
force-pushed
the
hs26gill/TF-5101-Add-name-filter-for-listing-projects
branch
from
March 23, 2023 19:40
606e94b
to
72369ca
Compare
brandonc
requested changes
Mar 23, 2023
hs26gill
force-pushed
the
hs26gill/TF-5101-Add-name-filter-for-listing-projects
branch
from
March 23, 2023 20:12
72369ca
to
2404aba
Compare
brandonc
previously approved these changes
Mar 23, 2023
jbonhag
reviewed
Mar 24, 2023
hs26gill
force-pushed
the
hs26gill/TF-5101-Add-name-filter-for-listing-projects
branch
from
March 24, 2023 17:47
2404aba
to
97e78e6
Compare
hs26gill
force-pushed
the
hs26gill/TF-5101-Add-name-filter-for-listing-projects
branch
from
March 24, 2023 17:49
97e78e6
to
3a071ac
Compare
nfagerlund
approved these changes
Mar 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like everyone's comments were addressed, and it seems good to me. 👍🏼
hs26gill
deleted the
hs26gill/TF-5101-Add-name-filter-for-listing-projects
branch
March 28, 2023 19:33
Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a name option for listing projects. This will allow the user with the ability to filter projects based on a given name. This also updates the
ProjectListOptions
as optional which is the expected behaviour.Testing plan
Unit Tests have been added/updated. To run them, please