Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hs26gill/TF-5101-Add-name-filter-for-listing-projects #668

Merged
merged 2 commits into from
Mar 28, 2023

Conversation

hs26gill
Copy link
Contributor

Description

This PR adds a name option for listing projects. This will allow the user with the ability to filter projects based on a given name. This also updates the ProjectListOptions as optional which is the expected behaviour.

Testing plan

Unit Tests have been added/updated. To run them, please

go test -run TestTeamsUpdateManageProjects  -v ./... -tags=integration

@hs26gill hs26gill requested a review from a team as a code owner March 23, 2023 18:49
project.go Show resolved Hide resolved
project.go Show resolved Hide resolved
@hs26gill hs26gill force-pushed the hs26gill/TF-5101-Add-name-filter-for-listing-projects branch from 606e94b to 72369ca Compare March 23, 2023 19:40
@hs26gill hs26gill requested a review from brandonc March 23, 2023 19:51
project.go Show resolved Hide resolved
project.go Show resolved Hide resolved
@hs26gill hs26gill force-pushed the hs26gill/TF-5101-Add-name-filter-for-listing-projects branch from 72369ca to 2404aba Compare March 23, 2023 20:12
brandonc
brandonc previously approved these changes Mar 23, 2023
project.go Outdated Show resolved Hide resolved
@hs26gill hs26gill force-pushed the hs26gill/TF-5101-Add-name-filter-for-listing-projects branch from 2404aba to 97e78e6 Compare March 24, 2023 17:47
@hs26gill hs26gill force-pushed the hs26gill/TF-5101-Add-name-filter-for-listing-projects branch from 97e78e6 to 3a071ac Compare March 24, 2023 17:49
Copy link
Member

@nfagerlund nfagerlund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like everyone's comments were addressed, and it seems good to me. 👍🏼

@hs26gill hs26gill merged commit 89e7909 into main Mar 28, 2023
@hs26gill hs26gill deleted the hs26gill/TF-5101-Add-name-filter-for-listing-projects branch March 28, 2023 19:33
@github-actions
Copy link

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants