feat: add missing fields from AdminSAMLSetting and AdminSAMLSettingsUpdateOptions structs

[karvounis-form3]

Description

This change is about adding missing fields to the AdminSAMLSetting and AdminSAMLSettingsUpdateOptions structs.

AdminSAMLSetting

Fields that appear in the JSON response of the TFE v202305-2 when calling the GET /api/v2/admin/saml-settings endpoint. Some of them were added to the AdminSAMLSetting struct.

$ curl -s --header "Authorization: Bearer $TFE_TOKEN" --header "Content-Type: application/vnd.api+json" --request GET https://$TFE_HOSTNAME/api/v2/admin/saml-settings | jq . 
{
  "data": {
    "id": "saml",
    "type": "saml-settings",
    "attributes": {
      "enabled": true,
      "debug": true,
      "idp-cert": "...",
      "old-idp-cert": "...",
      "slo-endpoint-url": "https://example.com/url",
      "sso-endpoint-url": "https://example.com/sso",
      "team-management-enabled": true,
      "attr-username": "...",
      "attr-groups": "MemberOf",
      "attr-site-admin": "SiteAdmin-test",
      "site-admin-role": "site-admins-test",
      "sso-api-token-session-timeout": 1111111,
      "acs-consumer-url": "...",
      "metadata-url": "...",
      "certificate": "testCertificate",
      "authn-requests-signed": true,
      "want-assertions-signed": true,
      "signature-signing-method": "SHA256",
      "signature-digest-method": "SHA1",
      "private-key": null
    }
  }
}

AdminSAMLSettingsUpdateOptions

Fields are also missing from the AdminSAMLSettingsUpdateOptions struct. The API request body of the PATCH /api/v2/admin/saml-settings request supports more fields.

TFE Documentation is not up to date with the current TFE API.

Closes: #730

Testing plan

External links

Output from tests

Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.

Read SAML settings

$ TFE_ADDRESS="https://example" ENABLE_TFE=1 go test -run TestAdminSettings_SAML_Read -v ./...

=== RUN   TestAdminSettings_SAML_Read
--- PASS: TestAdminSettings_SAML_Read (0.48s)
PASS
ok  	github.com/hashicorp/go-tfe	(cached)
?   	github.com/hashicorp/go-tfe/examples/configuration_versions	[no test files]
?   	github.com/hashicorp/go-tfe/examples/organizations	[no test files]
?   	github.com/hashicorp/go-tfe/examples/registry_modules	[no test files]
?   	github.com/hashicorp/go-tfe/examples/state_versions	[no test files]
?   	github.com/hashicorp/go-tfe/examples/users	[no test files]
?   	github.com/hashicorp/go-tfe/examples/workspaces	[no test files]
?   	github.com/hashicorp/go-tfe/mocks	[no test files]

Update SAML settings

$ TFE_ADDRESS="https://example" ENABLE_TFE=1 go test -run TestAdminSettings_SAML_Update -v ./... 

=== RUN   TestAdminSettings_SAML_Update
=== RUN   TestAdminSettings_SAML_Update/with_certificate_defined
=== RUN   TestAdminSettings_SAML_Update/with_team_management_defined
=== RUN   TestAdminSettings_SAML_Update/with_invalid_signature_digest_method
=== RUN   TestAdminSettings_SAML_Update/with_invalid_signature_signing_method
--- PASS: TestAdminSettings_SAML_Update (2.22s)
    --- PASS: TestAdminSettings_SAML_Update/with_certificate_defined (0.12s)
    --- PASS: TestAdminSettings_SAML_Update/with_team_management_defined (0.12s)
    --- PASS: TestAdminSettings_SAML_Update/with_invalid_signature_digest_method (0.12s)
    --- PASS: TestAdminSettings_SAML_Update/with_invalid_signature_signing_method (0.16s)
PASS
ok  	github.com/hashicorp/go-tfe	3.055s
?   	github.com/hashicorp/go-tfe/examples/configuration_versions	[no test files]
?   	github.com/hashicorp/go-tfe/examples/organizations	[no test files]
?   	github.com/hashicorp/go-tfe/examples/registry_modules	[no test files]
?   	github.com/hashicorp/go-tfe/examples/state_versions	[no test files]
?   	github.com/hashicorp/go-tfe/examples/users	[no test files]
?   	github.com/hashicorp/go-tfe/examples/workspaces	[no test files]
?   	github.com/hashicorp/go-tfe/mocks	[no test files]

[hashicorp-cla]

All committers have signed the CLA.

[karvounis-form3]

By the way, documentation is not up to date for:

• List SAML settings response
• update SAML Settings request body

[uturunku1]

Looks good! Thank you for your contribution @karvounis-form3 ! Whenever you are ready, go ahead merge this PR and close the GitHub issue.

[karvounis-form3]

@uturunku1 Unfortunately, I do not have proper permissions to merge this PR

This branch has no conflicts with the base branch
Only those with [write access](https://docs.github.com/articles/what-are-the-different-access-permissions) to this repository can merge pull requests.

[uturunku1]

@uturunku1 Unfortunately, I do not have proper permissions to merge this PR

This branch has no conflicts with the base branch
Only those with [write access](https://docs.github.com/articles/what-are-the-different-access-permissions) to this repository can merge pull requests.

Opps, my bad. I will merge this then!

[github-actions]

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.