Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid copying constraints for attribute schemas #426

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Avoid copying constraints for attribute schemas #426

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion schema/attribute_schema.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@ type AttributeSchema struct {

// Constraint represents expression constraint e.g. what types of
// expressions are expected for the attribute
//
// Constraints are immutable after construction by convention. It is
// particularly important not to mutate a constraint after it has been
// added to an AttributeSchema.
Constraint Constraint

// DefaultValue represents default value which applies
Expand Down Expand Up @@ -142,7 +146,8 @@ func (as *AttributeSchema) Copy() *AttributeSchema {
OriginForTarget: as.OriginForTarget.Copy(),
SemanticTokenModifiers: as.SemanticTokenModifiers.Copy(),
CompletionHooks: as.CompletionHooks.Copy(),
Constraint: as.Constraint.Copy(),
// We do not copy Constraint as it should be immutable
Constraint: as.Constraint,
}

return newAs
Expand Down