Use public scada address - scada.hashicorp.cloud #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing it to "scada.hashicorp.cloud" to remove the "internal" part of it. Note that existing URL will continue to work as its used by HCP dataplanes but we would like to avoid publishing an "internal" address to the public if possible. This is part of implementing https://hashicorp.atlassian.net/browse/HCPCO2-159.
manish-hashicorp
changed the title
manish-hashicorp
changed the title
bcmdarroch
approved these changes
Sep 9, 2022
|
Thanks for the review @bcmdarroch. Would it be possible to make a release after merging this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Description
Update the default scada address to "scada.hashicorp.cloud" to remove the "internal" part of it. Note that existing URL will continue to work as its used by HCP dataplanes but we would like to avoid publishing an "internal" address to the public if possible. This is part of implementing https://hashicorp.atlassian.net/browse/HCPCO2-159.
🔗 External Links
https://hashicorp.atlassian.net/browse/HCPCO2-159
🚢 Release Note
Release note for CHANGELOG:
👍 Definition of Done