Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Filter workspaces by current run status #419

Merged
merged 6 commits into from
Jul 9, 2024

Conversation

arybolovlev
Copy link
Contributor

@arybolovlev arybolovlev commented Jun 5, 2024

Description

This PR introduces a new approach for fetching workspaces that have pending current runs:

  • The List Workspaces API call has been extended to include filtering by the current run status, reducing the number of required API calls.
  • Add pagination handling to make sure all necessary workspaces are listed.
  • Add new log messages.

Tests

Usage Example

N/A.

References

Community Note

  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

@github-actions github-actions bot added dependencies Pull requests that update a dependency file golang controller size/L labels Jun 5, 2024
@arybolovlev arybolovlev force-pushed the use-current-run-filter branch 2 times, most recently from 432d807 to f6ae317 Compare June 5, 2024 17:37
@github-actions github-actions bot removed the dependencies Pull requests that update a dependency file label Jun 5, 2024
@arybolovlev arybolovlev force-pushed the use-current-run-filter branch from 809a827 to 73dbb2b Compare June 12, 2024 08:23
@arybolovlev arybolovlev marked this pull request as ready for review June 12, 2024 11:26
@arybolovlev arybolovlev requested a review from a team as a code owner June 12, 2024 11:26
@github-actions github-actions bot added documentation Improvements or additions to documentation dependencies Pull requests that update a dependency file helm-chart test size/XL and removed size/L labels Jul 8, 2024
@arybolovlev arybolovlev force-pushed the use-current-run-filter branch from 4eeb0a8 to 4098c55 Compare July 8, 2024 08:28
@github-actions github-actions bot added size/L and removed documentation Improvements or additions to documentation dependencies Pull requests that update a dependency file helm-chart size/XL labels Jul 8, 2024
@arybolovlev arybolovlev merged commit 6372886 into main Jul 9, 2024
7 checks passed
@arybolovlev arybolovlev deleted the use-current-run-filter branch July 9, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants