Apply suggestions from code review

Co-authored-by: Daniel Bennett <[email protected]>
hashicorp · Jan 8, 2025 · ba35c05 · ba35c05
1 parent 64726b5
commit ba35c05
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/client/hostvolumemanager/host_volumes_test.go b/client/hostvolumemanager/host_volumes_test.go
@@ -273,8 +273,9 @@ func TestHostVolumeManager_restoreFromState(t *testing.T) {
 		ID:       "test-vol-id-2",
 		HostPath: hostPath,
 		CreateReq: &cstructs.ClientHostVolumeCreateRequest{
-			Name: "registered-volume",
-			ID:   "test-vol-id-2",
+			Name:     "registered-volume",
+			ID:       "test-vol-id-2",
+			PluginID: "", // this signifies a Register operation
 		},
 	}
 

diff --git a/client/structs/host_volumes.go b/client/structs/host_volumes.go
@@ -55,7 +55,7 @@ type ClientHostVolumeRegisterRequest struct {
 	ID string
 
 	// Name is the name that group.volume will use to identify the volume
-	// source. Not expected to be unique.
+	// source. Not expected to be unique cluster-wide, but must be unique per node.
 	Name string
 
 	// NodeID is the node where the volume is placed. It's included in the

diff --git a/demo/hostvolume/no-plugin.volume.hcl b/demo/hostvolume/no-plugin.volume.hcl
@@ -6,8 +6,8 @@ type = "host"
 
 # this volume spec can be used with 'volume register' after filling in the
 # host_path and node_id values below
-host_path = "TODO"
-node_id   = "TODO"
+host_path = "TODO" # absolute path of the volume that was created out-of-band
+node_id   = "TODO" # ID of the node where the volume was created
 
 capability {
   access_mode     = "single-node-writer"