You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Basically what happens currently is that connect native tasks in bridge mode get a consul socket mounted in and CONSUL_HTTP_ADDR set accordingly (+ other CONSUL_*). in host network mode it only gets the other CONSUL_* variables set. Now if consul does not listen on the default port, one has to manually set CONSUL_HTTP_ADDR. For consistency reasons (and less surprises in general) I think that the connect hook should also configure the addr in host network mode. @shoenig seems to agree (see previous link).
Now there are two options:
Just set CONSUL_HTTP_ADRR via nomad to the consul addr it know
Remove the conditional mounting that now exists and mount the socket unconditionally (in connect native mode)
Now I understand that option two is not really needed because in host network mode there should be a way to reach consul via TCP already (most likely 127.0.0.1:8500), but I am wondering if from a consistency and code complexity quality option two should be preferred… What do you think? I might be able to offer code, but I cannot decide which of the two options is the way to go.
The text was updated successfully, but these errors were encountered:
I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.
This is a follow up to #8443 (comment)
Basically what happens currently is that connect native tasks in bridge mode get a consul socket mounted in and
CONSUL_HTTP_ADDR
set accordingly (+ otherCONSUL_*
). in host network mode it only gets the otherCONSUL_*
variables set. Now if consul does not listen on the default port, one has to manually setCONSUL_HTTP_ADDR
. For consistency reasons (and less surprises in general) I think that the connect hook should also configure the addr in host network mode. @shoenig seems to agree (see previous link).Now there are two options:
CONSUL_HTTP_ADRR
via nomad to the consul addr it knowNow I understand that option two is not really needed because in host network mode there should be a way to reach consul via TCP already (most likely 127.0.0.1:8500), but I am wondering if from a consistency and code complexity quality option two should be preferred… What do you think? I might be able to offer code, but I cannot decide which of the two options is the way to go.
The text was updated successfully, but these errors were encountered: