Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Affinity internalization may cause planning problems #10897

Closed
shoenig opened this issue Jul 14, 2021 · 1 comment · Fixed by #10904
Closed

Affinity internalization may cause planning problems #10897

shoenig opened this issue Jul 14, 2021 · 1 comment · Fixed by #10904
Assignees
@shoenig
Labels
stage/needs-investigation type/bug

Comments

@shoenig
Copy link
Contributor

shoenig commented Jul 14, 2021

I suspect the memoization in Affinity may cause a similar bug to #10896

Investigate and fix if needed
@shoenig shoenig self-assigned this Jul 15, 2021
shoenig added a commit that referenced this issue Jul 15, 2021
@shoenig
core: remove internalization of affinity strings
aa86392 
Basically the same as #10896 but with the Affinity struct.
Since we use reflect.DeepEquals for job comparison, there is
risk of false positives for changes due to a job struct with
memoized vs non-memoized strings.

Closes #10897
@shoenig shoenig mentioned this issue Jul 15, 2021
Merged
@notnoop notnoop mentioned this issue Jul 28, 2021
Merged
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@shoenig shoenig

Labels
stage/needs-investigation type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

core: remove internalization of affinity strings hashicorp/nomad
1 participant
@shoenig