Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: add missing client status "unknown" #17688

Closed
shoenig opened this issue Jun 22, 2023 · 1 comment · Fixed by #17726
Closed

api: add missing client status "unknown" #17688

shoenig opened this issue Jun 22, 2023 · 1 comment · Fixed by #17726
Labels
good first issue stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/api HTTP API and SDK issues type/bug
Milestone
1.6.0

Comments

@shoenig
Copy link
Contributor

shoenig commented Jun 22, 2023

On the nomad/ side we have AllocClientStatusUnknown, but on the api/ side this state is missing

https://github.com/hashicorp/nomad/blob/v1.5.6/nomad/structs/structs.go#L10022-L10029

https://github.com/hashicorp/nomad/blob/main/api/allocations.go#L27-L33

Update the API package to match all possible client status states.
@shoenig shoenig added type/bug theme/api HTTP API and SDK issues stage/accepted Confirmed, and intend to work on. No timeline committment though. labels Jun 22, 2023
@shoenig shoenig added this to the 1.6.0 milestone Jun 22, 2023
@shoenig shoenig mentioned this issue Jun 22, 2023
Merged
sejalapeno added a commit to sejalapeno/nomad that referenced this issue Jun 26, 2023
@sejalapeno
Update allocations.go
56ce1f3 
updated missing client status "unknown" hashicorp#17688
@sejalapeno sejalapeno mentioned this issue Jun 26, 2023
Merged
shoenig added a commit that referenced this issue Jun 26, 2023
@sejalapeno @shoenig
Update allocations.go (#17726)
05c84d6 
* Update allocations.go

updated missing client status "unknown" #17688

* changelog

* Update .changelog/17726.txt

adding relevant desc.

Co-authored-by: Seth Hoenig <[email protected]>

---------

Co-authored-by: Seth Hoenig <[email protected]>
This was referenced Jun 26, 2023
Merged
Merged
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/api HTTP API and SDK issues type/bug
Projects
None yet
Milestone
1.6.0
Development

Successfully merging a pull request may close this issue.

Update allocations.go sejalapeno/nomad
2 participants
@shoenig @jrasell