keyring: support external KMS for key encryption key (KEK) #23580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross
force-pushed
the
keyring-external-kms
branch
from
497983a to
fb740ed
Compare
tgross
force-pushed
the
keyring-external-kms
branch
from
fb740ed to
2b15046
Compare
tgross
force-pushed
the
keyring-external-kms
branch
from
2b15046 to
d720c5e
Compare
tgross
force-pushed
the
keyring-external-kms
branch
from
d720c5e to
02fd37c
Compare
tgross
force-pushed
the
keyring-external-kms
branch
from
02fd37c to
e7dde55
Compare
tgross
force-pushed
the
keyring-external-kms
branch
from
f80bfe3 to
fd75fe1
Compare
tgross
force-pushed
the
keyring-external-kms
branch
from
fd75fe1 to
56ada90
Compare
tgross
force-pushed
the
keyring-external-kms
branch
from
56ada90 to
0bbe907
Compare
tgross
force-pushed
the
keyring-external-kms
branch
from
0bbe907 to
ca0ad51
Compare
tgross
force-pushed
the
keyring-external-kms
branch
from
ca0ad51 to
8f123e7
Compare
In Nomad 1.4.0, we shipped support for encrypted Variables and signed Workload Identities, but the key material is protected only by a AEAD encrypting the KEK. Add support for Vault transit encryption and external KMS from major cloud providers. The servers call out to the external service to decrypt each key in the on-disk keystore. Ref: https://hashicorp.atlassian.net/browse/NET-10334 Fixes: #14852
tgross
force-pushed
the
keyring-external-kms
branch
from
f29a23d to
0f2ca08
Compare
tgross
added a commit
that referenced
this pull request
Jul 17, 2024
In #23580 we're implementing support for encrypting Nomad's key material with external KMS providers or Vault Transit. This changeset breaks out the documentation from that PR to keep the review manageable and present it to a wider set of reviewers. Ref: https://hashicorp.atlassian.net/browse/NET-10334 Ref: #14852 Ref: #23580
tgross
added a commit
that referenced
this pull request
Jul 17, 2024
In #23580 we're implementing support for encrypting Nomad's key material with external KMS providers or Vault Transit. This changeset breaks out the E2E infrastructure and testing from that PR to keep the review manageable. Ref: https://hashicorp.atlassian.net/browse/NET-10334 Ref: #14852 Ref: #23580
schmichael
approved these changes
Jul 17, 2024
Comment on lines
+103
to
+105
| // fallbackVaultConfig allows the transit provider to fallback to using the | ||
| // default Vault cluster's configuration block, instead of repeating those | ||
| // fields |
There was a problem hiding this comment.
Oh this is a really nice detail.
dduzgun-security
approved these changes
Jul 18, 2024
It's a good question. Unfortunately we only have an E2E environment for AWS (see #23601) for those tests. But fortunately the wrapper library's API is nicely designed such that the caller really doesn't have to care about the specifics, so then the wrapper library's own tests gives us the coverage we need to feel confident about shipping this. |
tgross
added a commit
that referenced
this pull request
Jul 18, 2024
In Nomad 1.4.0, we shipped support for encrypted Variables and signed Workload Identities, but the key material is protected only by a AEAD encrypting the KEK. Add support for Vault transit encryption and external KMS from major cloud providers. The servers call out to the external service to decrypt each key in the on-disk keystore. Ref: https://hashicorp.atlassian.net/browse/NET-10334 Fixes: #14852
tgross
added a commit
that referenced
this pull request
Jul 19, 2024
In #23580 we're implementing support for encrypting Nomad's key material with external KMS providers or Vault Transit. This changeset breaks out the E2E infrastructure and testing from that PR to keep the review manageable. Ref: https://hashicorp.atlassian.net/browse/NET-10334 Ref: #14852 Ref: #23580
tgross
added a commit
that referenced
this pull request
Jul 19, 2024
In #23580 we're implementing support for encrypting Nomad's key material with external KMS providers or Vault Transit. This changeset breaks out the documentation from that PR to keep the review manageable and present it to a wider set of reviewers. Ref: https://hashicorp.atlassian.net/browse/NET-10334 Ref: #14852 Ref: #23580
Closed
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Nomad 1.4.0, we shipped support for encrypted Variables and signed Workload Identities, but the key material is protected only by a AEAD encrypting the KEK. Add support for Vault transit encryption and external KMS from major cloud providers. The servers call out to the external service to decrypt each key in the on-disk keystore.
Ref: https://hashicorp.atlassian.net/browse/NET-10334
Fixes: #14852
Notes for reviewers: