Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: external KMS configuration #23600

Merged
merged 4 commits into from
Jul 19, 2024
Merged

docs: external KMS configuration #23600

merged 4 commits into from
Jul 19, 2024

Conversation

tgross
Copy link
Member

@tgross tgross commented Jul 16, 2024

In #23580 we're implementing support for encrypting Nomad's key material with external KMS providers or Vault Transit. This changeset breaks out the documentation from that PR to keep the review manageable and present it to a wider set of reviewers.

Ref: https://hashicorp.atlassian.net/browse/NET-10334
Ref: #14852
Ref: #23580

Preview link: https://nomad-git-docs-keyring-external-kms-hashicorp.vercel.app/nomad/docs/configuration/keyring
(and the other pages in this new section)


Note to reviewers:

@tgross
Copy link
Member Author

tgross commented Jul 16, 2024

cc @aimeeu for your thoughts as well

In #23580 we're implementing support for encrypting Nomad's key material with
external KMS providers or Vault Transit. This changeset breaks out the
documentation from that PR to keep the review manageable and present it to a
wider set of reviewers.

Ref: https://hashicorp.atlassian.net/browse/NET-10334
Ref: #14852
Ref: #23580
Copy link
Contributor

@aimeeu aimeeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I left a bunch of style guide nits.

website/content/docs/configuration/keyring/index.mdx Outdated Show resolved Hide resolved
website/content/docs/configuration/keyring/index.mdx Outdated Show resolved Hide resolved
website/content/docs/configuration/keyring/index.mdx Outdated Show resolved Hide resolved
website/content/docs/configuration/keyring/awskms.mdx Outdated Show resolved Hide resolved
website/content/docs/configuration/keyring/awskms.mdx Outdated Show resolved Hide resolved
website/content/docs/configuration/keyring/gcpckms.mdx Outdated Show resolved Hide resolved
website/content/docs/configuration/keyring/gcpckms.mdx Outdated Show resolved Hide resolved
website/content/docs/configuration/keyring/gcpckms.mdx Outdated Show resolved Hide resolved
Copy link
Member

@gulducat gulducat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! just some food for thought

Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/1.8.x backport to 1.8.x release line theme/docs Documentation issues and enhancements theme/keyring type/enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants