-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: external KMS configuration #23600
Conversation
deb559e
to
38193d7
Compare
ca0ad51
to
8f123e7
Compare
cc @aimeeu for your thoughts as well |
8f123e7
to
2167010
Compare
38193d7
to
1908f53
Compare
2167010
to
f29a23d
Compare
b4893fd
to
f55ffb7
Compare
f29a23d
to
0f2ca08
Compare
f55ffb7
to
afffa73
Compare
In #23580 we're implementing support for encrypting Nomad's key material with external KMS providers or Vault Transit. This changeset breaks out the documentation from that PR to keep the review manageable and present it to a wider set of reviewers. Ref: https://hashicorp.atlassian.net/browse/NET-10334 Ref: #14852 Ref: #23580
afffa73
to
512e150
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I left a bunch of style guide nits.
Co-authored-by: Aimee Ukasick <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! just some food for thought
6203c7a
to
e8ed289
Compare
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
In #23580 we're implementing support for encrypting Nomad's key material with external KMS providers or Vault Transit. This changeset breaks out the documentation from that PR to keep the review manageable and present it to a wider set of reviewers.
Ref: https://hashicorp.atlassian.net/browse/NET-10334
Ref: #14852
Ref: #23580
Preview link: https://nomad-git-docs-keyring-external-kms-hashicorp.vercel.app/nomad/docs/configuration/keyring
(and the other pages in this new section)
Note to reviewers:
I don't have all the KMS types available forFollow-up, we've decided not to ship those in the first release of this feature.seal
here: the keyring: support external KMS for key encryption key (KEK) #23580 PR doesn't include them yet and I'd rather wait until we're generally happy with the ideas of adding those more niche platforms (ex. OCI, AliCloud) before doing all the docs work for them.