Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSI snapshot list: do not shorten snapshot ID #10664

Merged
merged 1 commit into from
May 27, 2021
Merged

CSI snapshot list: do not shorten snapshot ID #10664

merged 1 commit into from
May 27, 2021

Conversation

ggriffiths
Copy link
Contributor

@ggriffiths ggriffiths commented May 27, 2021 •
edited
Loading

Fixes #10660
Signed-off-by: Grant Griffiths [email protected]

@vercel vercel bot temporarily deployed to Preview – nomad May 27, 2021 06:18 Inactive
@ggriffiths ggriffiths force-pushed the csilistsnapshot_verbose branch from 5574990 to 59414c4 Compare May 27, 2021 06:41
@vercel vercel bot temporarily deployed to Preview – nomad May 27, 2021 06:41 Inactive
@ggriffiths ggriffiths changed the title CSI: snapshot list do not shorten snapshot ID or volume ID CSI snapshot list: do not shorten snapshot ID or volume ID May 27, 2021
tgross
tgross requested changes May 27, 2021
View reviewed changes
command/volume_snapshot_list.go
for _, v := range snapshots {
rows = append(rows, fmt.Sprintf("%s|%s|%s|%s|%v",
limit(v.ID, length),
limit(v.ExternalSourceVolumeID, length),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The external volume ID can be extremely long for some cloud providers (ex. Azure) and I don't think it's required for Nomad CLI operations the way the snapshot ID is. It might be worth having the limit removed by the -verbose flag instead of by default for this field.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, I've updated this to still shorten the ExternalSourceVolumeID.

@ggriffiths ggriffiths force-pushed the csilistsnapshot_verbose branch from 59414c4 to 737317c Compare May 27, 2021 17:07
@vercel vercel bot temporarily deployed to Preview – nomad May 27, 2021 17:07 Inactive
@ggriffiths ggriffiths changed the title CSI snapshot list: do not shorten snapshot ID or volume ID CSI snapshot list: do not shorten snapshot ID May 27, 2021
@tgross
Copy link
Member

tgross commented May 27, 2021

LGTM!

@tgross tgross merged commit 9a315ad into hashicorp:main May 27, 2021
@tgross tgross added this to the 1.1.1 milestone May 27, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tgross tgross tgross approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.1
Development

Successfully merging this pull request may close these issues.

Nomad CSI snapshot list: do not shorten snapshot ID
2 participants
@ggriffiths @tgross