Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow up fixes for #11237 #11260

Merged
merged 2 commits into from
Oct 14, 2021
Merged

Follow up fixes for #11237 #11260

merged 2 commits into from
Oct 14, 2021

Conversation

apollo13
Copy link
Contributor

@apollo13 apollo13 commented Oct 5, 2021

/cc @jrasell

@vercel vercel bot temporarily deployed to Preview – nomad October 5, 2021 08:42 Inactive
@vercel vercel bot temporarily deployed to Preview – nomad October 5, 2021 14:09 Inactive
@vercel vercel bot temporarily deployed to Preview – nomad October 5, 2021 14:11 Inactive
@lgfa29 lgfa29 added this to the 1.2.0 milestone Oct 14, 2021
@vercel vercel bot temporarily deployed to Preview – nomad October 14, 2021 20:36 Inactive
lgfa29
lgfa29 approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @apollo13!

I pushed a commit to add a note so we don't miss this again in the future. We missed this in today's beta1 release, but it will be included in the final 1.2.0 release.

@lgfa29 lgfa29 merged commit cc8d944 into hashicorp:main Oct 14, 2021
@gjpin gjpin mentioned this pull request Oct 26, 2021
Closed
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lgfa29 lgfa29 lgfa29 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@apollo13 @lgfa29