CSI: add -secret and -parameter flags to volume snapshot create
#12360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross
force-pushed
the
csi-snapshot-create-secrets
branch
from
fb017a2 to
f1ee18b
Compare
tgross
force-pushed
the
csi-snapshot-create-secrets
branch
from
f1ee18b to
92b6493
Compare
tgross
changed the title
-secret flag in nomad volume snapshot create command-secret and -parameter flags to volume snapshot create
tgross
force-pushed
the
csi-snapshot-create-secrets
branch
from
92b6493 to
b13a203
Compare
tgross
force-pushed
the
csi-snapshot-create-secrets
branch
from
b13a203 to
d2ea348
Compare
tgross
force-pushed
the
csi-snapshot-create-secrets
branch
from
d2ea348 to
f9aa451
Compare
lgfa29
approved these changes
Mar 23, 2022
Pass-through the `-secret` and `-parameter` flags to allow setting parameters for the snapshot and overriding the secrets we've stored on the CSI volume in the state store.
tgross
force-pushed
the
csi-snapshot-create-secrets
branch
from
f9aa451 to
8fab5d2
Compare
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12318
Pass-through the
-secretand-parameterflags to allow settingparameters for the snapshot and overriding the secrets we've stored on
the CSI volume in the state store.