Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changelog: fix entries for #15522 and #15819 #15998

Merged
merged 2 commits into from
Feb 1, 2023
Merged

changelog: fix entries for #15522 and #15819 #15998

merged 2 commits into from
Feb 1, 2023

Conversation

lgfa29
Copy link
Contributor

@lgfa29 lgfa29 commented Jan 31, 2023

I noticed these while previewing the changelog from main.

Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@shoenig shoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could probably get the regex in tools/cl-entry to exclude " ... @lgfa29

@lgfa29
Copy link
Contributor Author

lgfa29 commented Feb 1, 2023

We could probably get the regex in tools/cl-entry to exclude " ... @lgfa29

I fiddle around with this, but I don't think it's actually possible without false positives. We would need to detect if the entire changelog text is enclosed in quotes, but something like ^[^"][a-z0-9/\s]+: .+[^"]$ prevents ending in quotes.

Maybe just adding a caret to require the input to start with a letter or number like ^[a-z0-9/\s]+: .+ would be enough for now?

@shoenig
Copy link
Contributor

shoenig commented Feb 1, 2023

We could also just do the blunt strings.HasPrefix/Suffix strings.Trim(")

@lgfa29
Copy link
Contributor Author

lgfa29 commented Feb 1, 2023

But that removes quotes that are valid, like:

bug: Fix config "my_config"

Becomes this when trimmed:

bug: Fix config "my_config

@lgfa29
Copy link
Contributor Author

lgfa29 commented Feb 1, 2023

I'm going with just the ^ for now. If we get more errors like this we can adjust it more. Thanks for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants