Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of hashicorp/go-msgpack v2 into release/1.3.x #16910

Merged

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #16810 to be assessed for backporting due to the inclusion of the label backport/1.3.x.

WARNING automatic cherry-pick of commits failed. Commits will require human attention.

The below text is copied from the body of the original PR.


Updates to v2 of both hashicorp/go-msgpack and hashicorp/net-rpc-msgpackrpc to resolve the dependency on a the retracted version, v1.1.5, of hashicorp/go-msgpack.

hashicorp/raft still depends on hashicorp/go-msgpack v0.5.5, which is now an indirect dependency.

Fixes #16808

@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/go-msgpack-v2/steadily-exciting-manatee branch from 8797b3f to 54cdd8a Compare April 17, 2023 21:02
@hashicorp-cla
Copy link

hashicorp-cla commented Apr 17, 2023

CLA assistant check
All committers have signed the CLA.

* Upgrade from hashicorp/go-msgpack v1.1.5 to v2.1.0

Fixes #16808

* Update hashicorp/net-rpc-msgpackrpc to v2 to match go-msgpack

* deps: use go-msgpack v2.0.0

go-msgpack v2.1.0 includes some code changes that we will need to
investigate furthere to assess its impact on Nomad, so keeping this
dependency on v2.0.0 for now since it's no-op.

---------

Co-authored-by: Luiz Aoqui <[email protected]>
@lgfa29 lgfa29 force-pushed the backport/go-msgpack-v2/steadily-exciting-manatee branch from 3ba5cc9 to db40ca6 Compare April 17, 2023 21:23
@lgfa29 lgfa29 merged commit 3b2da71 into release/1.3.x Apr 17, 2023
@lgfa29 lgfa29 deleted the backport/go-msgpack-v2/steadily-exciting-manatee branch April 17, 2023 21:45
lgfa29 added a commit that referenced this pull request May 1, 2023
lgfa29 added a commit that referenced this pull request May 1, 2023
This reverts commit 3b2da71.

Backport of #17047.

Co-authored-by: Luiz Aoqui <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants