Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of jobspec: add diff for Task Group Scaling block into release/1.6.x #18350

Merged

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #18332 to be assessed for backporting due to the inclusion of the label backport/1.6.x.

The below text is copied from the body of the original PR.


Without this diff nomad job plan won't report changes in scaling block.

Before:

$ nomad job plan job.hcl
+/- Job: "foo"
+/- Task Group: "foo" (1 create, 1 in-place update)
  +/- Count: "1" => "2" (forces create)
      Task: "foo"

After:

nomad job plan job.hcl
+/- Job: "foo"
+/- Task Group: "foo" (1 create, 1 in-place update)
  +/- Count: "1" => "2" (forces create)
  +   Scaling {
      + Enabled: "true"
      + Max:     "10"
      + Min:     "2"
      + Policy {
        + check[0][active_connections][0][query]:                                "scalar(open_connections_example_cache)"
        + check[0][active_connections][0][source]:                               "prometheus"
        + check[0][active_connections][0][strategy][0][target-value][0][target]: "20"
        + cooldown:                                                              "1m"
        + evaluation_interval:                                                   "5s"
        }
      }
      Task: "foo"

This PR is only for diff in TaskGroup Scaling block and not diff in Task Scaling block.


Overview of commits

@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/nvanthao/b-scaling-diff/only-unique-manatee branch from 726ca51 to be3c69b Compare August 28, 2023 22:37
@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/nvanthao/b-scaling-diff/only-unique-manatee branch from f32a96b to b1c9a29 Compare August 28, 2023 22:37
@vercel vercel bot temporarily deployed to Preview – nomad August 28, 2023 22:41 Inactive
@vercel vercel bot temporarily deployed to Preview – nomad-storybook-and-ui August 28, 2023 22:48 Inactive
@lgfa29 lgfa29 merged commit 6ed89b3 into release/1.6.x Aug 28, 2023
@lgfa29 lgfa29 deleted the backport/nvanthao/b-scaling-diff/only-unique-manatee branch August 28, 2023 23:14
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants