New endpoint: job/:id/actions #18690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philrenaud
force-pushed
the
18680-action-at-job-level-go
branch
from
594bf60 to
5cd0765
Compare
philrenaud
force-pushed
the
18680-action-at-job-level-go
branch
from
5cd0765 to
ae8f15e
Compare
tgross
reviewed
Oct 10, 2023
There was a problem hiding this comment.
Overall this looks pretty good @philrenaud. I've left some comments on a few areas we can clean things up or improve validation.
| t.Fatalf("err: %v", err) | ||
| } | ||
|
|
||
| // Check the output |
There was a problem hiding this comment.
Something to consider for this set of assertions is that the slice of actions will always get returned in the same order. So you should be able to compare against a fix slice of outputs. Something like:
must.Len(t, 10, actionsResp3)
must.Eq(t,
[]string{"date test", "echo test",....},
helper.ConvertSlice(actionsResp, func(a *Action) string { return a.Name }))
must.Eq(t,
[]string{"", "g", "g", "",....},
helper.ConvertSlice(actionsResp, func(a *Action) string { return a.TaskGroupName }))
philrenaud
force-pushed
the
18680-action-at-job-level-go
branch
from
af295bc to
0b66706
Compare
philrenaud
force-pushed
the
18680-action-at-job-level-go
branch
from
0b66706 to
572cc21
Compare
philrenaud
force-pushed
the
18680-action-at-job-level-go
branch
from
572cc21 to
e4be6fd
Compare
philrenaud
force-pushed
the
18627-scaffolding-task-actions
branch
from
f5de743 to
817667b
Compare
Base automatically changed from
18627-scaffolding-task-actions
to
18627-task-actions
October 11, 2023 20:36
philrenaud
changed the base branch from
18627-task-actions
to
18627-scaffolding-task-actions
philrenaud
changed the base branch from
18627-scaffolding-task-actions
to
18627-task-actions
philrenaud
force-pushed
the
18680-action-at-job-level-go
branch
from
e4be6fd to
2aa840c
Compare
tgross
approved these changes
Oct 12, 2023
philrenaud
added a commit
that referenced
this pull request
Oct 18, 2023
* unused param in action converter * backing out of parse_job level and moved toward new endpoint level * Adds taskName and taskGroupName to actions at job level * Unmodified job mock actions tests * actionless job test * actionless job test * Multi group multi task actions test * HTTP method check for GET, cleaner errors in job_endpoint_test * decomment
philrenaud
added a commit
that referenced
this pull request
Oct 20, 2023
* Scaffolding actions (#18639) * Task-level actions for job submissions and retrieval * FIXME: Temporary workaround to get ember dev server to pass exec through to 4646 * Update api/tasks.go Co-authored-by: Tim Gross <[email protected]> * Update command/agent/job_endpoint.go Co-authored-by: Tim Gross <[email protected]> * Diff and copy implementations * Action structs get their own file, diff updates to behave like our other diffs * Test to observe actions changes in a version update * Tests migrated into structs/diff_test and modified with PR comments in mind * APIActionToSTructsAction now returns a new value * de-comment some plain parts, remove unused action lookup * unused param in action converter --------- Co-authored-by: Tim Gross <[email protected]> * New endpoint: job/:id/actions (#18690) * unused param in action converter * backing out of parse_job level and moved toward new endpoint level * Adds taskName and taskGroupName to actions at job level * Unmodified job mock actions tests * actionless job test * actionless job test * Multi group multi task actions test * HTTP method check for GET, cleaner errors in job_endpoint_test * decomment * Actions aggregated at job model level (#18733) * Removal of temporary fix to proxy to 4646 * Run Action websocket endpoint (#18760) * Working demo for review purposes * removal of cors passthru for websockets * Remove job_endpoint-specific ws handlers and aimed at existing alloc exec handlers instead * PR comments adressed, no need for taskGroup pass, better group and task lookups from alloc * early return in action validate and removed jobid from req args per PR comments * todo removal, we're checking later in the rpc * boolean style change on tty * Action CLI command (#18778) * Action command init and stuck-notes * Conditional reqpath to aim at Job action endpoint * De-logged * General CLI command cleanup, observe namespace, pass action as string, get random alloc w group adherence * tab and varname cleanup * Remove action param from Allocations().Exec calls * changelog * dont nil-check acl --------- Co-authored-by: Tim Gross <[email protected]>
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new endpoint: /job/:id/actions
It parses through a job's taskgroups' tasks, and extracts their actions up to a single flat array with the name of task and taskGroup included as fields.
Resolves #18680