docs: deprecate rsadecrypt #18856
Merged
docs: deprecate rsadecrypt #18856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`rsadecrypt` uses PKCS #1 v1.5 padding which has multiple known weaknesses. While it is possible to use safely in Nomad, we should not encourage our users to use bad cryptographic primitives. If users want to decrypt secrets in jobspecs we should choose a cryptographic primitive designed for that purpose. `rsadecrypt` was inherited from Terraform which only implemented it to support decrypting Window's passwords on AWS EC2 instances: hashicorp/terraform#16647 This is not something that should ever be done in a jobspec, therefore there's no reason for Nomad to support this HCL2 function.
angrycub
reviewed
Oct 24, 2023
website/content/docs/job-specification/hcl2/functions/crypto/rsadecrypt.mdx
Outdated
Show resolved
Hide resolved
schmichael
added
backport/website
This was referenced Oct 24, 2023
|
@schmichael Did you keep the whitespace standoff after the opening tag. If not, the markdown doesn't render. If so, it should render the markdown inside |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rsadecryptusesPKCS #1 v1.5padding which has multiple known weaknesses. While it is possible to use safely in Nomad, we should not encourage our users to use bad cryptographic primitives.If users want to decrypt secrets in jobspecs we should choose a cryptographic primitive designed for that purpose.
rsadecryptwas inherited from Terraform which only implemented it to support decrypting Window's passwords on AWS EC2 instances:hashicorp/terraform#16647
This is not something that should ever be done in a jobspec, therefore there's no reason for Nomad to support this HCL2 function.
Preview to save you a few clicks:
