Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Omit the current-time-displaying components during our visual diff tests #22435

Merged
merged 1 commit into from
May 31, 2024

Conversation

philrenaud
Copy link
Contributor

@philrenaud philrenaud commented May 31, 2024

Visual diff tests with Percy are generated at test-time, which means that our components show time-sensitive things (like "last updated at" times for allocations) will trigger a "something changed" warning. This hides those time-sensitive things for a recently-added test.

Copy link

Ember Test Audit comparison

main 1de4f17 change
passes 1572 1572 0
failures 0 0 0
flaky 0 0 0
duration 11m 28s 181ms 11m 26s 816ms -01s 365ms

@philrenaud philrenaud requested review from schmichael and gulducat May 31, 2024 17:23
@philrenaud philrenaud merged commit 784ec50 into main May 31, 2024
18 checks passed
@philrenaud philrenaud deleted the b-ui/stabilize-percy-job-ui-block-snapshots branch May 31, 2024 17:41
Copy link

github-actions bot commented Jan 5, 2025

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/1.8.x backport to 1.8.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants