Backport of e2e: fix failing tests due to docker plugin settings into release/1.9.x #24235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-nomad-core
force-pushed
the
backport/f-e2e-docker-podman-simplify/informally-cool-dodo
branch
from
2b5aabd to
9570750
Compare
pkazmierczak
approved these changes
Oct 17, 2024
pkazmierczak
deleted the
backport/f-e2e-docker-podman-simplify/informally-cool-dodo
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #24234 to be assessed for backporting due to the inclusion of the label backport/1.9.x.
The below text is copied from the body of the original PR.
24215 introduced a fix for a docker auth bug and added e2e tests to cover it. Sadly, by modifying nomad client config on all clients and not setting up the registry before we run any tests causes, as you might expect, all tests involving docker to fail. PicardRikerFacepalm.gif
This PR disables the new docker e2e tests and we'll revisit the topic in #24233
Overview of commits