Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: provide empty implementations of cgroup helpers for non-root nomad #24392

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

shoenig
Copy link
Contributor

@shoenig shoenig commented Nov 7, 2024

This PR fixes a regression in #24340 where non-root Nomad agents would panic when using the raw_exec driver. No CL because that change hasn't been released yet.

Verified

This commit was signed with the committer’s verified signature.
jrjohnson Jon Johnson
… nomad
@shoenig shoenig force-pushed the fix-non-root-nomad-cgroups-path branch from 86dedb4 to b96d90e Compare November 7, 2024 16:20
@shoenig shoenig marked this pull request as ready for review November 7, 2024 16:50
@shoenig shoenig requested review from tgross and jrasell November 7, 2024 16:50
@shoenig shoenig added backport/ent/1.9.x+ent Changes are backported to 1.9.x+ent backport/1.9.x backport to 1.9.x release line labels Nov 7, 2024
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shoenig shoenig merged commit a0ff073 into main Nov 7, 2024
32 checks passed
@shoenig shoenig deleted the fix-non-root-nomad-cgroups-path branch November 7, 2024 18:24
Copy link

github-actions bot commented Mar 8, 2025

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/ent/1.9.x+ent Changes are backported to 1.9.x+ent backport/1.9.x backport to 1.9.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants